Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix resizer blocking paginator elements #5874

Merged
merged 1 commit into from
Jul 26, 2019
Merged

Fix resizer blocking paginator elements #5874

merged 1 commit into from
Jul 26, 2019

Conversation

epwinchell
Copy link
Contributor

@epwinchell epwinchell commented Jul 25, 2019

This PR fixes a problem where the screen resizer was blocking the "select all" checkbox (and possibly other elements) in the paging bar.

https://bugzilla.redhat.com/show_bug.cgi?id=1729894

Old
Screen Shot 2019-07-25 at 10 05 42 AM

New
Screen Shot 2019-07-25 at 10 36 43 AM

@epwinchell
Copy link
Contributor Author

@miq-bot add_label bug, formatting/styling, hammer/yes, ivanchuk/yes, blocker

@miq-bot
Copy link
Member

miq-bot commented Jul 25, 2019

Checked commit https://github.com/epwinchell/manageiq-ui-classic/commit/f94ae3522d7e74be4df796724393dc37f77a7008 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🍪

@martinpovolny martinpovolny self-assigned this Jul 26, 2019
@martinpovolny martinpovolny added this to the Sprint 117 Ending Aug 5, 2019 milestone Jul 26, 2019
@martinpovolny martinpovolny merged commit 0e01ff0 into ManageIQ:master Jul 26, 2019
simaishi pushed a commit that referenced this pull request Jul 26, 2019
 Fix resizer blocking paginator elements

(cherry picked from commit 0e01ff0)

https://bugzilla.redhat.com/show_bug.cgi?id=1729894
@simaishi
Copy link
Contributor

Ivanchuk backport details:

$ git log -1
commit 9bd51a8c99f106943edb4a7d50ff71d9071b5f89
Author: Martin Povolny <mpovolny@redhat.com>
Date:   Fri Jul 26 09:29:35 2019 +0200

    Merge pull request #5874 from epwinchell/1729894
    
     Fix resizer blocking paginator elements
    
    (cherry picked from commit 0e01ff0bbc9234f495a68427fd8d0f2568aebe50)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1729894

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants