user_input_filter: Don't autofocus selects #5906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
user input filter autofocuses the first input element, but pf-select hides the select element and creates its own div. That div never changes the text inside when chosing options, if the original select is focused. Making sure we don't autofocus select elements. Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1677258
|
Checked commit https://github.com/himdel/manageiq-ui-classic/commit/3c285dd167afb16022ea311d894666ad422c195d with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
simaishi
pushed a commit
that referenced
this pull request
Jul 31, 2019
user_input_filter: Don't autofocus selects (cherry picked from commit 00fa111) https://bugzilla.redhat.com/show_bug.cgi?id=1677258
|
Ivanchuk backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compute > Infra > VMs > VMs accordion,
add an advanced search like "VM.active" "=" "<user input>" - the field needs to be a boolean,
try to use it.
Before: there would be a Choose / True / False select, but chosing anything would just show Choose
Now: you should be able to chose a value.
(And field types other than bool should still have the input autofocused.)
The user input filter autofocuses the first input element,
but pf-select hides the select element and creates its own div.
That div never changes the text inside when chosing options, if the original select is focused.
Making sure we don't autofocus select elements.
Fixes #5896
https://bugzilla.redhat.com/show_bug.cgi?id=1677258