Make the check against Satellite organization safe to fix RHSM issues #5908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Checked commit skateman@c86c936 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
h-kataria
approved these changes
Jul 30, 2019
simaishi
pushed a commit
that referenced
this pull request
Jul 30, 2019
Make the check against Satellite organization safe to fix RHSM issues (cherry picked from commit d182270) https://bugzilla.redhat.com/show_bug.cgi?id=1731962
|
Ivanchuk backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you try to add your credentials for Red Hat Subscription Manager under
Settings -> Region -> Red Hat Updates, the workflow breaks on a type conversion error which has been introduced to support organization for Satellite. The fix is to usetryand convert the data to number so the comparison never fails.@miq-bot add_label bug, hammer/yes, ivanchuk/yes
@miq-bot add_reviewer @h-kataria
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1731962