views: remove unneeded compliances join #5919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some databases, this brings back way too many records. It is unnecessary. And if it were necessary, it will get automatically anyway See also ManageIQ#5283 https://bugzilla.redhat.com/show_bug.cgi?id=1733351
|
Checked commit kbrock@174f9be with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
simaishi
pushed a commit
that referenced
this pull request
Aug 1, 2019
views: remove unneeded compliances join (cherry picked from commit fc8c491) https://bugzilla.redhat.com/show_bug.cgi?id=1733351
|
Ivanchuk backport details: |
simaishi
pushed a commit
that referenced
this pull request
Aug 14, 2019
views: remove unneeded compliances join (cherry picked from commit fc8c491) https://bugzilla.redhat.com/show_bug.cgi?id=1738266
|
Hammer backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some databases, this brings back way too many records.
It is unnecessary. And if it were necessary, the includes would get added automatically anyway.
See also #5283
https://bugzilla.redhat.com/show_bug.cgi?id=1733351