Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update datepicker when start date changed #5920

Conversation

mzazrivec
Copy link
Contributor

  1. Create a new report schedule
  2. Choose some starting date in the future
  3. Change Run between Hourly and something else
  4. Watch the start date changing to either today or tomorrow
  5. Open the datepicker (by clicking on the input field)

Without this fix, the datepicker would not reflect the change of the starting date.

https://bugzilla.redhat.com/show_bug.cgi?id=1729882

@miq-bot
Copy link
Member

miq-bot commented Aug 1, 2019

Checked commit mzazrivec@30092a5 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 👍

@romanblanco
Copy link
Member

@mzazrivec while editing a schedule in Configuration (ops) - Settings, there seems to be a similar form, but the Starting Date doesn't change with Run field. Is that an intention, or an inconsistency issue?

Copy link
Member

@romanblanco romanblanco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, works 👍

@mzazrivec
Copy link
Contributor Author

while editing a schedule in Configuration (ops) - Settings, there seems to be a similar form, but the Starting Date doesn't change with Run field. Is that an intention, or an inconsistency issue?

That one is written in angular (I think).

@martinpovolny martinpovolny merged commit c371d84 into ManageIQ:master Aug 6, 2019
@martinpovolny martinpovolny added this to the Sprint 118 Ending Aug 19, 2019 milestone Aug 6, 2019
@martinpovolny martinpovolny self-assigned this Aug 6, 2019
@mzazrivec mzazrivec deleted the update_datepicker_when_start_date_changed branch August 6, 2019 13:10
simaishi pushed a commit that referenced this pull request Aug 6, 2019
…date_changed

Update datepicker when start date changed

(cherry picked from commit c371d84)

https://bugzilla.redhat.com/show_bug.cgi?id=1729882
@simaishi
Copy link
Contributor

simaishi commented Aug 6, 2019

Ivanchuk backport details:

$ git log -1
commit 7c9d30602b562a8ed7e30718f80659970119f648
Author: Martin Povolny <mpovolny@redhat.com>
Date:   Tue Aug 6 14:59:48 2019 +0200

    Merge pull request #5920 from mzazrivec/update_datepicker_when_start_date_changed
    
    Update datepicker when start date changed
    
    (cherry picked from commit c371d8462174aa346986dba09e27f70736884f1d)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1729882

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants