Changed model name when showing list of Tower Templates. #5925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
previously code was passing in model as `ConfigurationScript` that returns all Tower templates, Changed to use `ManageIQ::Providers::AnsibleTower::AutomationManager::ConfigurationScript` so that embedded ansible templates are excluded from the list Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1656734
h-kataria
force-pushed
the
fix_list_of_ansible_tower_templates
branch
from
9523e01
to
1b96857
Compare
|
Checked commit h-kataria@1b96857 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
simaishi
pushed a commit
that referenced
this pull request
Aug 2, 2019
…plates Changed model name when showing list of Tower Templates. (cherry picked from commit e440234) https://bugzilla.redhat.com/show_bug.cgi?id=1656734
|
Ivanchuk backport details: |
h-kataria
added a commit
to h-kataria/manageiq-ui-classic
that referenced
this pull request
Sep 4, 2019
Fixed class name that was changed in ManageIQ#5925, previously made change was excluding Workflow Templates in UI. Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1747589
h-kataria
added a commit
to h-kataria/manageiq-ui-classic
that referenced
this pull request
Sep 4, 2019
Fixed class name that was changed in ManageIQ#5925, previously made change was excluding Workflow Templates in UI. Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1747589
h-kataria
added a commit
to h-kataria/manageiq-ui-classic
that referenced
this pull request
Sep 4, 2019
Fixed class name that was changed in ManageIQ#5925, previously made change was excluding Workflow Templates in UI. Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1747589
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
previously code was passing in model as
ConfigurationScriptthat returns all Tower templates, Changed to useManageIQ::Providers::AnsibleTower::AutomationManager::ConfigurationScriptso that embedded ansible templates are excluded from the listFixes https://bugzilla.redhat.com/show_bug.cgi?id=1656734
before
after
