-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed call that build list of Storages to build Host file drop down #5952
Fixed call that build list of Storages to build Host file drop down #5952
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
d7d9aae
to
6616c36
Compare
Issue was introduced in ManageIQ#3956, in commit 6df12d1 code that builds Host file drop down was changed `vm.try(:available_iso_names)` was removed and new method `get_iso_options` was added to build the list. Changed to get all storages that the vm's host is attached to instead of all of the vm's storages Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1689369
6616c36
to
5747aff
Compare
Checked commit h-kataria@5747aff with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…econfigure_vms Fixed call that build list of Storages to build Host file drop down (cherry picked from commit 24d94fb) https://bugzilla.redhat.com/show_bug.cgi?id=1689369
Ivanchuk backport details:
|
Issue was introduced in #3956, in commit 6df12d1 code that builds Host file drop down was changed
vm.try(:available_iso_names)
was removed and new methodget_iso_options
was added to build the list. Changed to get all storages that the vm's host is attached to instead of all of the vm's storagesFixes https://bugzilla.redhat.com/show_bug.cgi?id=1689369
before
after
cc @agrare