Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HAMMER] Add Set Ownership to Auth Key Pairs #5967

Merged
merged 2 commits into from
Aug 15, 2019

Conversation

PanSpagetka
Copy link
Contributor

@PanSpagetka PanSpagetka commented Aug 8, 2019

Add Set Ownership to Auth Key Pairs for Hammer.
Master PR: #5973

Links [Optional]

https://bugzilla.redhat.com/show_bug.cgi?id=1589766
https://bugzilla.redhat.com/show_bug.cgi?id=1730066
ManageIQ/manageiq#19124

Screenshots

Screenshot from 2019-08-08 14-41-39
Screenshot from 2019-08-08 14-38-53
Screenshot from 2019-08-08 14-40-43

@miq-bot miq-bot changed the title Add Set Ownership to Auth Key Pairs [HAMMER] Add Set Ownership to Auth Key Pairs Aug 8, 2019
@PanSpagetka PanSpagetka force-pushed the add-ownership-auth-keypair branch 2 times, most recently from d0114da to 95582ce Compare August 8, 2019 13:01
@PanSpagetka
Copy link
Contributor Author

ping @lpichler @h-kataria

@h-kataria
Copy link
Contributor

@PanSpagetka we will need to add this in the Product features as well.

@PanSpagetka
Copy link
Contributor Author

@miq-bot add_label pending core
ManageIQ/manageiq#19124

@PanSpagetka PanSpagetka reopened this Aug 13, 2019
@lpichler
Copy link
Contributor

👍 work great regard to RBAC. and regard to UI I found that it is not possible set owner ship from lists:

Screenshot 2019-08-13 at 19 23 06

@miq-bot
Copy link
Member

miq-bot commented Aug 14, 2019

Checked commits PanSpagetka/manageiq-ui-classic@8a9471f~...f32e860 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
6 files checked, 4 offenses detected

app/controllers/auth_key_pair_cloud_controller.rb

app/helpers/application_helper/toolbar/auth_key_pair_cloud_center.rb

app/helpers/application_helper/toolbar/auth_key_pair_clouds_center.rb

@PanSpagetka
Copy link
Contributor Author

Now it should be ok...

Copy link
Contributor

@lpichler lpichler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 works great 👍

@lpichler
Copy link
Contributor

NOTE: core PR is merged

@h-kataria
Copy link
Contributor

@simaishi ManageIQ/manageiq#19124 needs to be backported

@simaishi simaishi self-assigned this Aug 15, 2019
@simaishi simaishi merged commit 920ecdd into ManageIQ:hammer Aug 15, 2019
@simaishi simaishi added this to the Sprint 118 Ending Aug 19, 2019 milestone Aug 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants