-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use react-codemirror onChange event instead of onBeforeChange. #6030
Merged
h-kataria
merged 1 commit into
ManageIQ:master
from
Hyperkid123:tweak-react-code-editor
Aug 16, 2019
Merged
Use react-codemirror onChange event instead of onBeforeChange. #6030
h-kataria
merged 1 commit into
ManageIQ:master
from
Hyperkid123:tweak-react-code-editor
Aug 16, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cc @h-kataria |
+1 for that! Tried it locally and it saves us from changing properties on that page, so we can avoid weird workarounds. |
@lina-nikiforova is there anything else i can do for you? |
miq-bot
changed the title
[WIP] Use react-codemirror onChange event instead of onBeforeChange.
Use react-codemirror onChange event instead of onBeforeChange.
Aug 15, 2019
Hyperkid123
force-pushed
the
tweak-react-code-editor
branch
from
August 15, 2019 14:51
f913555
to
0212eff
Compare
Hyperkid123
force-pushed
the
tweak-react-code-editor
branch
from
August 15, 2019 14:52
0212eff
to
d7dec1a
Compare
Checked commit Hyperkid123@d7dec1a with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
h-kataria
approved these changes
Aug 16, 2019
simaishi
pushed a commit
that referenced
this pull request
Sep 30, 2020
Use react-codemirror onChange event instead of onBeforeChange. (cherry picked from commit 471bc69) https://bugzilla.redhat.com/show_bug.cgi?id=1740753
Ivanchuk backport details:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1740753
Trying to use different event handlers to make QE testing easier.