Add a type column to the list of images in the pre-prov flow

[mansam]

This adds a type column to the pre-provision image-select screen to differentiate images from snapshots.

Depends upon ManageIQ/manageiq#12970

[chessbyte]

@gmcculloug @tzumainn please review

[tzumainn]

Would it make sense to have the Type column next to the Name column? That matches the other updated Images table. Just let me know if you disagree!

Other than that, looks great! I've verified that it works and properly distinguishes between images and snapshots.

[gmcculloug]

Would agree with @tzumainn that we should be consistent. Only wish I knew what other "Images table" you were referring to. 😕

[tzumainn]

@gmcculloug Ah, you can see it here: ManageIQ/manageiq#12970

It's the listing of images that you get when you click on 'Images' from the providers table.

[dclarizio]

@tzumainn @gmcculloug any thoughts on moving the column position? Is this ready to go?

[tzumainn]

@mansam can you move the type column to something approximating what you did on the other PR?

@dclarizio this one depends on ManageIQ/manageiq#12970, which has not yet been merged

[miq-bot]

Checked commits mansam/manageiq-ui-classic@e83c31f~...3481b46 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
2 files checked, 1 offense detected

app/views/miq_request/_pre_prov.html.haml

• ⚠️ - Line 22 - Missing curly braces around a hash parameter.

[mansam]

@tzumainn @dclarizio The type column's been moved to the right of the name column to better match the pending Cloud Image view changes. Changing the column order meant I had to either rearrange the hash in miq_request_methods.rb::build_vm_grid in an ugly way, or I had to refactor the view itself to change the order. Since the view should be doing all the presentation and was already making assumptions about the column ordering, I made the view entirely responsible for that. (It feels better to me to have the ordering all in one place, rather than having to change the header order in build_vm_grid and the actual column order in _pre_prov.html.haml.)

[tzumainn]

👍 re-tested, looks good to me!

[h-kataria]

LGTM

[dclarizio]

@mansam @tzumainn please ping me once the core PR is merged

[tzumainn]

@dclarizio Hi! The PR upon which this depends was merged - can this one be merged now?