Remove Timelines tab from Report editor #6181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
h-kataria
reviewed
Sep 12, 2019
| if @tl_changed # Reload the screen if the timeline data was changed | ||
| page.replace_html("tl_sample_div", :partial => "form_tl_sample") if @tl_field != ReportHelper::NOTHING_STRING | ||
| elsif @formatting_changed # Reload the screen if the formatting pulldowns need to be reset | ||
| if @formatting_changed # Reload the screen if the formatting pulldowns need to be reset | ||
| page.replace_html("formatting_div", :partial => "form_formatting") | ||
| elsif @tl_repaint |
There was a problem hiding this comment.
@bmclaughlin should this go away too?
|
@bmclaughlin can you also review following, i think those can be removed too |
bmclaughlin
force-pushed
the
bz1743651
branch
from
41e0b52
to
efbcfb7
Compare
|
Checked commits bmclaughlin/manageiq-ui-classic@fddc085~...efbcfb7 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 spec/controllers/miq_report_controller/reports/editor_spec.rb
|
|
Thanks for the review @h-kataria! I removed the lines you mentioned above and ran into no errors unit testing and running the specs locally. 👍 |
simaishi
pushed a commit
that referenced
this pull request
Dec 16, 2019
Remove Timelines tab from Report editor (cherry picked from commit a58ce1a) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1784183
|
Ivanchuk backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
After:
@miq-bot add_labels bug
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1743651