Fixed lost focus on code editor after first state update. #6249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Hyperkid123 Cannot apply the following label because they are not recognized: ivanchuk yes |
|
Checked commit Hyperkid123@f9050b7 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@miq-bot add_label ivanchuk/yes |
rvsia
approved these changes
Sep 30, 2019
simaishi
pushed a commit
that referenced
this pull request
Sep 30, 2020
Fixed lost focus on code editor after first state update. (cherry picked from commit fced5af) https://bugzilla.redhat.com/show_bug.cgi?id=1754543
|
Ivanchuk backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1754543
The issue here was with passing anonymous function to
FieldProvide. It did not have any reference to it and was creating new instance of that component instead of updating its props. That caused loosing the focus of the field. By wrapping the children and naming the component the issue is fixed.I also removed the value from state and let parent component handle it.