Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the displaying of the flash message(s) in policy list #628

Merged

Conversation

jzigmund
Copy link

@jzigmund jzigmund commented Mar 8, 2017

When the user wants to add new policy (to the parent accordion w/o any record) and cancel the creation, no flash message displays. This PR is fixing that by adding the partial view to support displaying of the flash messages when no records are under the accordion.

https://bugzilla.redhat.com/show_bug.cgi?id=1404473

@jzigmund
Copy link
Author

jzigmund commented Mar 8, 2017

@miq-bot add_label ui,bug

@miq-bot
Copy link
Member

miq-bot commented Mar 8, 2017

Checked commits jzigmund/manageiq-ui-classic@dbb7381~...6d389ba with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks good. ⭐

@jzigmund jzigmund changed the title Fix the appearance of the flash message in policy list Fix the displaying of the flash message(s) in policy list Mar 8, 2017
@mzazrivec mzazrivec self-assigned this Mar 9, 2017
@mzazrivec mzazrivec added this to the Sprint 56 Ending Mar 13, 2017 milestone Mar 9, 2017
@mzazrivec mzazrivec merged commit ef67ebd into ManageIQ:master Mar 9, 2017
@simaishi
Copy link
Contributor

Euwe backport (to manageiq repo) details:

$ git log -1
commit b75453bc231fd092808d02c4e562f37f9267d365
Author: Milan Zázrivec <mzazrivec@redhat.com>
Date:   Thu Mar 9 12:05:38 2017 +0100

    Merge pull request #628 from jzigmund/bz1404473-no_flash_on_cancel_new_policy
    
    Fix the displaying of the flash message(s) in policy list
    (cherry picked from commit ef67ebdc100c79d7ecdb231ff56cee12d903a13b)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1431154

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants