Optimization - consistent date formats #6385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the ruby ui code is using `session[:user_tz]` for timezone conversions, providing the same value to JS world. Except rails time zone names are non-standard, so converting to the Etc/UTC, America/New_York, ... format.
This makes sure that Optimization lists convert time to 24h, with time zone, the same format that's coming from /api/results/20892?expand_value_format=true&hash_attribute=result_set Previously, we would output show_list dates in the browser-local timezone, in 12h + am/pm format, now, we output all the dates in user-set timezone, 24h, including the timezone abbreviation. Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1769333
|
Checked commits https://github.com/himdel/manageiq-ui-classic/compare/a9fe50e60ea9cc2400a23494c326f9ceea7646e7~...7e83f20044f307782764cc62a66295229c81cbec with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
mzazrivec
approved these changes
Nov 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview > Optimization,
in the show_list views (
/optimization/show_listand/optimization/show_list/123), we convert iso dates to the user representation in JS.But, for saved report views (both in Optimization and in Reports), we use the formatted value provided by the API (
/api/results/20892?expand_value_format=true&hash_attribute=result_set).Before, the show_list value was formatted as "07/22/2019 9:44:50 am", in browser-local timezone.
Now, the show_list value is formatted as "07/22/2019 09:44:50 UTC", in the timezone set in user settings.
This also exposes the current user timezone (
session[:user_tz]) to JS (ManageIQ.timezone), in theEurope/London/Etc/UTC... format.Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1769333