Add page title for custom menu items. #6387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinpovolny
force-pushed
the
menu_title_custom
branch
2 times, most recently
from
5b7450b
to
5bb588f
Compare
martinpovolny
force-pushed
the
menu_title_custom
branch
from
5bb588f
to
b14e062
Compare
martinpovolny
force-pushed
the
menu_title_custom
branch
from
b14e062
to
6bb5c4b
Compare
|
Checked commit martinpovolny@6bb5c4b with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
mzazrivec
approved these changes
Nov 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Custom menu items (added throught settings) do not have a nice page title (html
<TITLE>tag).The current one is calculated from the ID of the section (
@layout).Fixing that to use the menu item's
nameinstead.Ping @himdel