Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Policy: simplify handling of @trees, make in an array. #6398

Merged
merged 1 commit into from
Nov 12, 2019

Conversation

martinpovolny
Copy link
Member

@martinpovolny martinpovolny commented Nov 11, 2019

Trying to help with #6329

  • @trees has to be an array (set it app/controllers/application_controller.rb)
  • handle tree building the same way other controllers do (via build_replaced_trees)
  • remove dead code

Ping @himdel, @rvsia

@martinpovolny martinpovolny changed the title Policy: simplify handling of @trees, make in an array. [WIP] Policy: simplify handling of @trees, make in an array. Nov 11, 2019
@miq-bot miq-bot added the wip label Nov 11, 2019
@miq-bot
Copy link
Member

miq-bot commented Nov 11, 2019

Checked commit martinpovolny@d0672c9 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 🏆

@martinpovolny martinpovolny changed the title [WIP] Policy: simplify handling of @trees, make in an array. Policy: simplify handling of @trees, make in an array. Nov 11, 2019
@mzazrivec mzazrivec added this to the Sprint 125 Ending Nov 11, 2019 milestone Nov 12, 2019
@mzazrivec mzazrivec self-assigned this Nov 12, 2019
@mzazrivec mzazrivec merged commit 692989d into ManageIQ:master Nov 12, 2019
@ZitaNemeckova
Copy link
Contributor

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1811689

@miq-bot add_label ivanchuk/yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants