Allow performing operations on Instances of a chosen Cloud Network #6458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot add_label bug |
hstastna
changed the title
hstastna
force-pushed
the
Operations_Instances_of_CloudNetwork
branch
from
072e9ee
to
0f95c73
Compare
hstastna
changed the title
hstastna
force-pushed
the
Operations_Instances_of_CloudNetwork
branch
2 times, most recently
from
ade62a3
to
55f3c4e
Compare
hstastna
changed the title
hstastna
force-pushed
the
Operations_Instances_of_CloudNetwork
branch
15 times, most recently
from
cf970f0
to
8b50d56
Compare
hstastna
changed the title
hstastna
force-pushed
the
Operations_Instances_of_CloudNetwork
branch
from
8b50d56
to
c9f8ec9
Compare
hstastna
force-pushed
the
Operations_Instances_of_CloudNetwork
branch
from
c9f8ec9
to
8b4d26b
Compare
hstastna
force-pushed
the
Operations_Instances_of_CloudNetwork
branch
from
8b4d26b
to
0431835
Compare
hstastna
force-pushed
the
Operations_Instances_of_CloudNetwork
branch
from
0431835
to
f384298
Compare
|
Checked commit hstastna@f384298 with ruby 2.5.5, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #6309
This PR fixes the issue regarding Instances displayed through a Cloud Network's Relationships: nothing happened in the UI for almost all of the operations in the toolbar, for some operations error
No template found for CloudNetworkController#buttonoccurred.The logic for operations on nested list of Instances was missing, in
cloud_networkcontroller. I'm adding appropriate logic by usingbuttonmethod from GenericButtonMixin.In this PR, I'm also adding missing routes for managing policies of selected Instances.
Also Check Compliance of Last Known Configuration action will be fixed after merging this PR together with #6426 (MERGED).
This PR does not fix:
cloud_network. The issue regarding buttons will be fixed in a follow up PR. More about this issue: No Submit, Cancel buttons for Evacuate selected Instances in a nested list #6480Before: (nothing happens in the UI, after clicking on Manage Policies in the toolbar)
After: (Managing Policies for selected Instance works well)
