Display name of Container Pod instead of HTML in Container Build's Textual summary #6575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot add_label bug |
hstastna
changed the title
|
@miq-bot remove_label wip |
This was referenced Jan 6, 2020
|
@ZitaNemeckova @himdel @martinpovolny Could you, please, review this? Thank you 🙏 |
hstastna
force-pushed
the
HTML_ContainerBuild_summary_table
branch
from
3b62227
to
31caca1
Compare
|
Checked commit hstastna@31caca1 with ruby 2.5.5, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
|
Changelog entry to be composed with #6577 (something like "Fixed display of 'Build Instances' under Container Pod") |
martinpovolny
added
textual summaries
compute/cloud
compute/containers
and removed
compute/cloud
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #6572
There was HTML code in the Build Instances table in textual summary of selected Container Build. I've replaced
link_tobyvalue.link+value.valuein this PR. Making the link look like a link wil be done in a follow up PR (in react-ui-components repo).Before:
After:
