Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add APP_PATH to allow using Rails directly #6647

Merged
merged 2 commits into from
Feb 4, 2020

Conversation

Fryguy
Copy link
Member

@Fryguy Fryguy commented Feb 3, 2020

This PR enables running rails console and rails server directly from the manageiq-ui-classic using the spec/manageiq as the containing app.

@himdel Please review

@Fryguy
Copy link
Member Author

Fryguy commented Feb 3, 2020

@himdel I figured this out trying to run the Rails server from Travis with the right contexts. It also turns out we can do this in every plugin, so even provider plugins now can do rails console.

@miq-bot
Copy link
Member

miq-bot commented Feb 3, 2020

Checked commits Fryguy/manageiq-ui-classic@9823994~...c469962 with ruby 2.5.5, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🍰

@himdel
Copy link
Contributor

himdel commented Feb 4, 2020

Oh, cool :) that should come in handy, thanks! :)

One thing I notice, there's an extra "irb: warn: can't alias context from irb_context." when running that way..

@himdel himdel merged commit 827782d into ManageIQ:master Feb 4, 2020
@himdel himdel added this to the Sprint 130 Ending Feb 17, 2020 milestone Feb 4, 2020
@Fryguy Fryguy deleted the make_rails_work branch February 4, 2020 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants