Added "Copy from Provisioning" button on Retirement tab. #732
Conversation
h-kataria
force-pushed
the
copy_provisioning_button
branch
from
1763ea1
to
2a7faf6
Compare
|
@syncrou Please review. |
|
@h-kataria This does not seem to effect cloud credential. Otherwise it is working. |
| vm.catalogItemModel.retirement_dialog_name = vm.catalogItemModel.provisioning_dialog_name; | ||
| vm.catalogItemModel.retirement_key = ''; | ||
| vm.catalogItemModel.retirement_value = ''; | ||
| vm.catalogItemModel.retirement_variables = angular.copy(vm.catalogItemModel.provisioning_variables); |
There was a problem hiding this comment.
@h-kataria - Do we have to worry about the ae_instance (retirement entry points - 'yes_without_playbook', 'no_without_playbook' etc.) getting set here as well? - Possibly that is pulled in already from the vm.catalogItemModel object, and already exists?
There was a problem hiding this comment.
@syncrou that is already set when the form loads, no need to set when copying provisioning fields.
|
👍 Looks good to me. |
|
@gmcculloug i am looking into cloud credential drop down issue. |
Added Copy from Provisioning button on Retirement tab, that pops up a confirmation modal when button is pressed with Cancel/Copy buttons. https://www.pivotaltracker.com/story/show/140338133
h-kataria
force-pushed
the
copy_provisioning_button
branch
from
2a7faf6
to
094462f
Compare
|
@gmcculloug addressed issue found with cloud credential drop down when copying data from provisioning. |
|
Checked commits h-kataria/manageiq-ui-classic@094462f~...7c38501 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
Retested cloud credentials - Looks good. Thanks. |
|
Looks good. |
|
@martinpovolny can you please merge. |
Added Copy from Provisioning button on Retirement tab, that pops up a confirmation modal when button is pressed with Cancel/Copy buttons.
https://www.pivotaltracker.com/story/show/140338133
before
after:
@epwinchell please review
@gmcculloug please review/test
cc @dclarizio