Enable attach/detach operations to storage manager #746
Conversation
|
@AparnaKarve can you have a look at this one? If not, please assign to someone who can. |
|
This pull request is not mergeable. Please rebase and repush. |
gberginc
force-pushed
the
enable_attach_detach_for_storage_manager
branch
from
12fe1d6
to
c04d0f6
Compare
|
@gberginc Please rebase and repush. That should take care of the Hakiri security warnings and hopefully the Travis build too. LGTM otherwise. |
Attaching volume is currently not possible from within the list of cloud volumes of a chosen storage manager because the handler in `ems_common` does not have a path for the button (even though attach/detach option is enabled). This patch adds the missing handlers and redirects to the required `cloud_volume` controller.
gberginc
force-pushed
the
enable_attach_detach_for_storage_manager
branch
from
c04d0f6
to
4ab2e7f
Compare
|
Checked commit gberginc@4ab2e7f with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
@AparnaKarve thanks for LGTM! @h-kataria this is now green. |
|
Fine? |
|
Thanks @martinpovolny! |
|
No problem. @gberginc : should this go to the Fine release? |
|
@gberginc @martinpovolny #997 is already backported to Fine branch without attach/detach. Can you create a Fine PR that covers change in PR 997 as well? |
|
@mmojzis This PR was not backported to Fine yet and hence the issue in https://bugzilla.redhat.com/show_bug.cgi?id=1459190 still persists. |
|
Backported to Fine via #1776 |
Attaching volume is currently not possible from within the list of cloud volumes of a chosen storage manager because the handler in
ems_commondoes not have a path for the button (even though attach/detach option is enabled).This patch adds the missing handlers and redirects to the required
cloud_volumecontroller.Video: http://x.k00.fr/6wmos (apologies for a short switch to the terminal, but I had a
binding.prythere).Somewhat related to #715 where I added ability to create new cloud volume from within the storage manager volume list.
@miq-bot add_label bug,storage