Fix actions' icons of policy events #754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Before fix: After fix: |
| success + failure | ||
| end | ||
|
|
||
| private |
There was a problem hiding this comment.
the use of private is really useless here, as CC wrote
see line 5
|
Assigning to @mzazrivec as I was too involved. |
jzigmund
force-pushed
the
bz1410910-wrong_icon_for_policy_actions
branch
from
bb185b5
to
e8c6260
Compare
|
Checked commit jzigmund@e8c6260 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
@jzigmund TreeNodeBuilder refactoring was |
|
@simaishi backported PR for Euwe ManageIQ/manageiq#14972 |
|
Backported to Euwe via ManageIQ/manageiq#14972 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tree node was not able to get information about the action's flag inside the builder, so I augmented the returned instances by adding new instance variable with the flag.
https://bugzilla.redhat.com/show_bug.cgi?id=1410910