Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hiding Network Credentials drop down from UI #757

Merged
merged 1 commit into from
Mar 21, 2017

Conversation

h-kataria
Copy link
Contributor

@h-kataria h-kataria commented Mar 21, 2017

Hiding Network Credentials drop down from UI until we have support to add/edit Network type Credentials in UI.

https://www.pivotaltracker.com/story/show/141970189

before:
before_network_cred_remove

before_757_changes

after
after_network_cred_removed

after_757_changes

@gmcculloug please review.

@gmcculloug
Copy link
Member

Network Credential support is planned for the next phase of this feature so I am good with just disabling this for now.

@h-kataria Network Credential is still displayed on the Catalog Item summary screen.

Hiding Network Credentials drop down from UI until we have support to add/edit Network type Credentials in UI.

https://www.pivotaltracker.com/story/show/141970189
@miq-bot
Copy link
Member

miq-bot commented Mar 21, 2017

Checked commit h-kataria@64c9f89 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
2 files checked, 12 offenses detected

app/views/catalog/_sandt_tree_show.html.haml

  • ⚠️ - Line 216 - Comment should have a space after the #
  • ⚠️ - Line 216 - Missing space after #.
  • ⚠️ - Line 217 - Comment should have a space after the #
  • ⚠️ - Line 217 - Missing space after #.
  • ⚠️ - Line 219 - Comment should have a space after the #
  • ⚠️ - Line 219 - Missing space after #.

app/views/layouts/angular/_ansible_form_options_angular.html.haml

  • ⚠️ - Line 64 - Comment should have a space after the #
  • ⚠️ - Line 64 - Missing space after #.
  • ⚠️ - Line 65 - Comment should have a space after the #
  • ⚠️ - Line 65 - Missing space after #.
  • ⚠️ - Line 67 - Comment should have a space after the #
  • ⚠️ - Line 67 - Missing space after #.

@h-kataria
Copy link
Contributor Author

@gmcculloug please re-test.

@gmcculloug
Copy link
Member

Looks good, thanks. @dclarizio Please review.

@dclarizio dclarizio merged commit 65f6d9a into ManageIQ:master Mar 21, 2017
@dclarizio dclarizio added this to the Sprint 57 Ending Mar 27, 2017 milestone Mar 21, 2017
@h-kataria h-kataria deleted the hide_network_credentials branch March 21, 2017 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants