Add control that id is not nil otherwise set it to new

[ZitaNemeckova]

Introduced by #379 . So @miq-bot add_label euwe/yes, darga/yes, bug, trees

https://bugzilla.redhat.com/show_bug.cgi?id=1434857

Configuration -> Access Control -> Group -> Configuration -> Add new Group -> select anything from trees

Before:

After:

[h-kataria]

@ZitaNemeckova can you add a spec test to verify this fix.

[miq-bot]

This pull request is not mergeable. Please rebase and repush.

[miq-bot]

Checked commits ZitaNemeckova/manageiq-ui-classic@e6f2824~...4331d85 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
5 files checked, 1 offense detected

app/presenters/tree_builder.rb

• ❗ - Line 186, Col 5 - Style/TernaryParentheses - Omit parentheses for ternary conditions.

[ZitaNemeckova]

@miq-bot remove_label wip
@h-kataria please review. Thanks :)

[dclarizio]

@ZitaNemeckova the BZ is marked as 5.8, shouldn't this only be labeled as fine/yes, but not for the other releases?

[chrispy1]

@miq-bot add_label fine/yes

[h-kataria]

looks good.

[simaishi]

Fine backport details:

$ git log -1
commit 971471429d5ced8b84fd9010489ef6474756daeb
Author: Harpreet Kataria <hkataria@redhat.com>
Date:   Mon Apr 17 17:15:59 2017 -0400

    Merge pull request #811 from ZitaNemeckova/bz1434857
    
    Add control that id is not nil otherwise set it to new
    (cherry picked from commit 1895ce6a49144235dbc4458a0639df6d97912d66)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1442891

[simaishi]

@ZitaNemeckova TreeBuilder refactoring is causing conflict backporting to euwe branch... Please resolve conflict and create an Euwe-specific PR (referencing this one) or suggest other PRs to backport.

Euwe backport conflict:

$ git status
On branch euwe
Your branch is up-to-date with 'origin/euwe'.
You are currently cherry-picking commit 1895ce6.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:

	modified:   app/presenters/tree_builder.rb
	modified:   spec/presenters/tree_builder_tags_spec.rb

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)

	deleted by us:   app/presenters/tree_builder_belongs_to_hac.rb
	both modified:   app/presenters/tree_builder_tags.rb
	deleted by us:   spec/presenters/tree_builder_belongs_to_hac_spec.rb

[ZitaNemeckova]

@simaishi Euwe version: ManageIQ/manageiq#15098

[simaishi]

Backported to Euwe via ManageIQ/manageiq#15098