Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cockpit button for cloud instance. #820

Merged
merged 1 commit into from
Mar 28, 2017

Conversation

martinpovolny
Copy link
Member

Fixes:

https://bugzilla.redhat.com/show_bug.cgi?id=1414543

Not sure if we want just the button (as I added) or we want the full access menu.

Seems to me the access menu has only one valid option in the cloud atm. so adding just the button

ping @dclarizio .

@miq-bot
Copy link
Member

miq-bot commented Mar 28, 2017

Checked commit martinpovolny@1098ea5 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 2 offenses detected

app/helpers/application_helper/toolbar/x_vm_cloud_center.rb

  • ❗ - Line 132, Col 5 - Style/IndentArray - Use 2 spaces for indentation in an array, relative to the first position after the preceding left parenthesis.
  • ❗ - Line 141, Col 3 - Style/IndentArray - Indent the right bracket the same as the first position after the preceding left parenthesis.

@dclarizio
Copy link

@martinpovolny

Not sure if we want just the button (as I added) or we want the full access menu.

Can we verify what we do for other areas where the cockpit button is shown?
Also, please check the security warning.
Thx, Dan

@martinpovolny
Copy link
Member Author

@dclarizio : The security warning was there before and was actually fixed by @mzazrivec today. Please, ignore it in this PR.

@dclarizio dclarizio self-assigned this Mar 28, 2017
@dclarizio dclarizio merged commit 2d8a076 into ManageIQ:master Mar 28, 2017
@dclarizio dclarizio added this to the Sprint 58 Ending Apr 10, 2017 milestone Mar 28, 2017
simaishi pushed a commit that referenced this pull request Apr 4, 2017
@simaishi
Copy link
Contributor

simaishi commented Apr 4, 2017

Fine backport details:

$ git log -1
commit 90812cf341f5b13991974f20db59a64ceade65e3
Author: Dan Clarizio <dclarizi@redhat.com>
Date:   Tue Mar 28 11:59:52 2017 -0700

    Merge pull request #820 from martinpovolny/instance_cockpit
    
    Add cockpit button for cloud instance.
    (cherry picked from commit 2d8a076dd56f19956d45d08b7e4788f7d8dc7a9a)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1438856

@martinpovolny martinpovolny deleted the instance_cockpit branch November 28, 2017 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants