Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add RBAC check to process_managers. #848

Merged
merged 2 commits into from
Mar 31, 2017
Merged

Add RBAC check to process_managers. #848

merged 2 commits into from
Mar 31, 2017

Conversation

martinpovolny
Copy link
Member

@martinpovolny martinpovolny commented Mar 30, 2017 •
edited
Loading

Ping @PanSpagetka, @romanblanco

I have pushed the RBAC check one step deeper making the code simpler.

Please, review.

@martinpovolny martinpovolny force-pushed the process_managers_rbac branch 2 times, most recently from 17f8125 to 697e80d Compare March 31, 2017 08:32
@miq-bot
Copy link
Member

miq-bot commented Mar 31, 2017

This pull request is not mergeable. Please rebase and repush.

@miq-bot
Copy link
Member

miq-bot commented Mar 31, 2017

Checked commits martinpovolny/manageiq-ui-classic@5ce5422~...ed7b8d2 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks good. ⭐

PanSpagetka
PanSpagetka approved these changes Mar 31, 2017
View reviewed changes
Copy link
Contributor

@PanSpagetka PanSpagetka left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, also it seems to be working in UI.

@PanSpagetka
Copy link
Contributor

@himdel ping

@himdel himdel added this to the Sprint 58 Ending Apr 10, 2017 milestone Mar 31, 2017
@himdel himdel self-assigned this Mar 31, 2017
@himdel himdel merged commit 9b7a59e into ManageIQ:master Mar 31, 2017
@himdel
Copy link
Contributor

himdel commented Mar 31, 2017

LGTM, the only difference I'm seeing is that when an ems with that id doesn't exist, instead of "%record no longer exists", you'll get "error during refresh_ems: undefined method process_tasks for NilClass:Class".

simaishi pushed a commit that referenced this pull request Mar 31, 2017
@himdel @simaishi
Merge pull request #848 from martinpovolny/process_managers_rbac
d35aabe 
Add RBAC check to process_managers.
(cherry picked from commit 9b7a59e)
@simaishi
Copy link
Contributor

Fine backport details:

$ git log -1
commit d35aabe9058a8a779b14e20bb8c26934a7333e9f
Author: Martin Hradil <himdel@seznam.cz>
Date:   Fri Mar 31 12:16:30 2017 +0000

    Merge pull request #848 from martinpovolny/process_managers_rbac
    
    Add RBAC check to process_managers.
    (cherry picked from commit 9b7a59e8ddda1eee931f8086043fcad2182a8bb5)

@martinpovolny martinpovolny deleted the process_managers_rbac branch November 28, 2017 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PanSpagetka PanSpagetka PanSpagetka approved these changes

Assignees

@himdel himdel

Labels
bug fine/backported rbac
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@martinpovolny @miq-bot @PanSpagetka @himdel @simaishi