Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RBAC checking in ci_processing #852

Merged
merged 20 commits into from
Mar 31, 2017
Merged

RBAC checking in ci_processing #852

merged 20 commits into from
Mar 31, 2017

Conversation

romanblanco
Copy link
Member

@romanblanco romanblanco commented Mar 30, 2017 •
edited
Loading

continuation of #799

PanSpagetka and others added 20 commits March 30, 2017 16:35
@PanSpagetka @romanblanco
Check RBAC in set_ownership method
3808cad
@PanSpagetka @romanblanco
Add RBAC check for resize_vms
3008082
@PanSpagetka @romanblanco
Add RBAC check for live_migrate_vm
a935857
@PanSpagetka @romanblanco
Add RBAC check for live_migrate_finished
1a0137e
@PanSpagetka @romanblanco
Add RBAC check for evacuate_vm
0c26ba5
@PanSpagetka @romanblanco
Add RBAC check for vm_right_size
8f0450f
@PanSpagetka @romanblanco
Add RBAC check for reconfigurevms
c8bf5a7
@PanSpagetka @romanblanco
Add RBAC check for vm_button_operation
35dca73
@PanSpagetka @romanblanco
Add RBAC check for manager_button_operation
a1395dd
@PanSpagetka @romanblanco
Add RBAC check for polsimvms
12b34cb
@PanSpagetka @romanblanco
Add RBAC check for cluster_button_operation
4106027
@PanSpagetka @romanblanco
Add RBAC check for host_button_operation
92859c1
@PanSpagetka @romanblanco
Add RBAC check for storage_button_operation
dbffaea
@PanSpagetka @romanblanco
Add RBAC check for deletestorages
2eb49bc
@PanSpagetka @romanblanco
Add RBAC check for delete_elements
e0848fc
@PanSpagetka @romanblanco
Change test_item_with_rbac
b89f789
@PanSpagetka @romanblanco
Add missing space.
3bf7a93
@romanblanco
Renamed 'find_by_id_filtered' method
e0baf1b 
renamed in dad3455
@romanblanco
Renamed 'find_checked_items_with_rbac' method
3f9a28a 
renamed in c45960e
@romanblanco
Removed method for testing single record for RBAC
0f1824d 
added in ec883d5
@romanblanco
Copy link
Member Author

@martinpovolny ping

@miq-bot
Copy link
Member

miq-bot commented Mar 30, 2017

Checked commits romanblanco/manageiq-ui-classic@3808cad~...0f1824d with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 2 offenses detected

app/controllers/application_controller/ci_processing.rb

  • ❗ - Line 1819, Col 9 - Style/CommentAnnotation - Annotation keywords like FIXME should be all upper case, followed by a colon, and a space, then a note describing the problem.
  • ❗ - Line 1899, Col 9 - Style/CommentAnnotation - Annotation keywords like FIXME should be all upper case, followed by a colon, and a space, then a note describing the problem.

@martinpovolny martinpovolny reopened this Mar 30, 2017
@martinpovolny
Copy link
Member

Travis is red and I am not sure that it's all unrelated. Reopening...

Ping @PanSpagetka, @romanblanco

@martinpovolny martinpovolny changed the title Update changes from PR #799 by changes from PR #779 RBAC checking in ci_processing Mar 31, 2017
@martinpovolny martinpovolny self-assigned this Mar 31, 2017
@martinpovolny martinpovolny merged commit 0e739bd into ManageIQ:master Mar 31, 2017
@martinpovolny martinpovolny added this to the Sprint 58 Ending Apr 10, 2017 milestone Mar 31, 2017
@romanblanco romanblanco deleted the pr799 branch March 31, 2017 08:32
simaishi pushed a commit that referenced this pull request Mar 31, 2017
@martinpovolny @simaishi
Merge pull request #852 from romanblanco/pr799
7043bf0 
RBAC checking in ci_processing
(cherry picked from commit 0e739bd)
@simaishi
Copy link
Contributor

Fine backport details:

$ git log -1
commit 7043bf00b16c84cbb080eba72eb377f28eff92a4
Author: Martin Povolny <mpovolny@redhat.com>
Date:   Fri Mar 31 10:30:38 2017 +0200

    Merge pull request #852 from romanblanco/pr799
    
    RBAC checking in ci_processing
    (cherry picked from commit 0e739bdb690ac856feb3e392f31da0f51207c369)

@lpichler lpichler mentioned this pull request Apr 3, 2017
Merged
@lgalis lgalis mentioned this pull request Apr 3, 2017
Merged
@martinpovolny martinpovolny mentioned this pull request Jun 6, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@martinpovolny martinpovolny

Labels
bug fine/backported rbac
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@romanblanco @miq-bot @martinpovolny @simaishi @PanSpagetka