Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds Topology in the menu for Physical Infrastructure #862

Merged
merged 1 commit into from
Apr 3, 2017
Merged

Adds Topology in the menu for Physical Infrastructure #862

merged 1 commit into from
Apr 3, 2017

Conversation

AparnaKarve
Copy link
Contributor

@AparnaKarve AparnaKarve commented Mar 31, 2017 •
edited
Loading

Requires the Product Feature id in ManageIQ/manageiq#14589

screen shot 2017-03-30 at 5 12 52 pm

@himdel As requested, Topology would now appear in the default menu, but for the menu to be visible you would need ManageIQ/manageiq#14589 merged.

@AparnaKarve AparnaKarve mentioned this pull request Mar 31, 2017
Merged
@AparnaKarve AparnaKarve force-pushed the add_phy_infra_topology_to_default_menu branch from 7db17bd to e9aa707 Compare March 31, 2017 00:16
@miq-bot
Copy link
Member

miq-bot commented Mar 31, 2017

Checked commit AparnaKarve@e9aa707 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks good. 🍰

@martinpovolny martinpovolny added this to the Sprint 58 Ending Apr 10, 2017 milestone Apr 3, 2017
@martinpovolny
Copy link
Member

fine?

@martinpovolny martinpovolny merged commit 798ca9a into ManageIQ:master Apr 3, 2017
@martinpovolny martinpovolny self-assigned this Apr 3, 2017
@himdel himdel added the fine/yes label Apr 5, 2017
@himdel
Copy link
Contributor

himdel commented Apr 5, 2017

Added fine/yes because PHinfra topology is broken without this and dependencies..

simaishi pushed a commit that referenced this pull request Apr 5, 2017
@martinpovolny @simaishi
Merge pull request #862 from AparnaKarve/add_phy_infra_topology_to_de…
9ab9f21 
…fault_menu

Adds Topology in the menu for Physical Infrastructure
(cherry picked from commit 798ca9a)
@simaishi
Copy link
Contributor

simaishi commented Apr 5, 2017

Fine backport details:

$ git log -1
commit 9ab9f21ecb1930072345a8358028f1ce088389ca
Author: Martin Povolny <mpovolny@redhat.com>
Date:   Mon Apr 3 11:21:51 2017 +0200

    Merge pull request #862 from AparnaKarve/add_phy_infra_topology_to_default_menu
    
    Adds Topology in the menu for Physical Infrastructure
    (cherry picked from commit 798ca9a214aeccc49cec8da5c73f3a89212f26f4)

@AparnaKarve AparnaKarve deleted the add_phy_infra_topology_to_default_menu branch July 26, 2017 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@martinpovolny martinpovolny

Labels
enhancement fine/backported menus
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AparnaKarve @miq-bot @martinpovolny @himdel @simaishi