Fixed variable name to display value of extra_vars on Retirement tab #875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syncrou
reviewed
Mar 31, 2017
| @@ -314,8 +314,8 @@ | |||
| %th | |||
| = _("Default value") | |||
| %tbody | |||
| - if retirement[:extra_vars] | |||
| - retirement[:extra_vars].each do |key, value| | |||
There was a problem hiding this comment.
@h-kataria - did this ever work? - Or did something else change at the controller level which no longer passed retirement in?
| - if retirement[:extra_vars] | ||
| - retirement[:extra_vars].each do |key, value| | ||
| - if @record.config_info[:retirement][:extra_vars] | ||
| - @record.config_info[:retirement][:extra_vars].each do |key, value| |
There was a problem hiding this comment.
I tested this - it works for me.
h-kataria
force-pushed
the
show_extra_vars_on_retirement_tab
branch
from
cf5b5f2
to
0ac5791
Compare
|
Checked commit h-kataria@0ac5791 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
@dclarizio please review/merge |
simaishi
pushed a commit
that referenced
this pull request
Apr 4, 2017
Fixed variable name to display value of extra_vars on Retirement tab (cherry picked from commit 3393d3c) https://bugzilla.redhat.com/show_bug.cgi?id=1438825
|
Fine backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugzilla.redhat.com/show_bug.cgi?id=1437496
@syncrou @gmcculloug please review/test
before:
after:
