Added RBAC check in catalog controller #887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romanblanco
commented
Apr 3, 2017
| @@ -707,7 +707,7 @@ def ot_copy_submit | |||
|
|
|||
| def ot_remove_submit | |||
| assert_privileges("orchestration_template_remove") | |||
| checked = find_checked_items | |||
| checked = find_checked_ids_with_rbac(OrchestrationTemplate) | |||
| checked[0] = params[:id] if checked.blank? && params[:id] | |||
| elements = OrchestrationTemplate.where(:id => checked) | |||
There was a problem hiding this comment.
Hm, looking at this, I'm thinking using find_checked_records_with_rbac may be better here. ☝️
That way I don't need to check params[:id] for RBAC too.
romanblanco
force-pushed
the
fix_rbac_catalog
branch
from
28fa564
to
bc791fa
Compare
romanblanco
force-pushed
the
fix_rbac_catalog
branch
from
bc791fa
to
7282a0c
Compare
|
Checked commits romanblanco/manageiq-ui-classic@167e9b4~...7282a0c with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 app/controllers/application_controller.rb
|
simaishi
pushed a commit
that referenced
this pull request
Apr 3, 2017
Added RBAC check in catalog controller (cherry picked from commit 4425e78)
|
Fine backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@martinpovolny @PanSpagetka ping