Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix RBAC for floating ips #963

Merged
merged 1 commit into from
Apr 7, 2017
Merged

Fix RBAC for floating ips #963

merged 1 commit into from
Apr 7, 2017

Conversation

PanSpagetka
Copy link
Contributor

@PanSpagetka PanSpagetka commented Apr 7, 2017 •
edited
Loading

Fix RBAC in floating_ips_controller. Buttons for this action are not present in UI, I introduce them in #962

@PanSpagetka PanSpagetka changed the title Fix rbac for floating ips Fix RBAC for floating ips Apr 7, 2017
@miq-bot
Copy link
Member

miq-bot commented Apr 7, 2017

Checked commit PanSpagetka@300518b with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks good. 🍪

@martinpovolny martinpovolny merged commit 2dad101 into ManageIQ:master Apr 7, 2017
@martinpovolny martinpovolny added this to the Sprint 58 Ending Apr 10, 2017 milestone Apr 7, 2017
@martinpovolny martinpovolny self-assigned this Apr 7, 2017
simaishi pushed a commit that referenced this pull request Apr 7, 2017
@martinpovolny @simaishi
Merge pull request #963 from PanSpagetka/fix-rbac-for-floating-ips
125df6a 
Fix RBAC for floating ips
(cherry picked from commit 2dad101)
@simaishi
Copy link
Contributor

simaishi commented Apr 7, 2017

Fine backport details:

$ git log -1
commit 125df6a014f867c7e44c3796ea7c4d111c17c204
Author: Martin Povolny <mpovolny@redhat.com>
Date:   Fri Apr 7 15:59:36 2017 +0200

    Merge pull request #963 from PanSpagetka/fix-rbac-for-floating-ips
    
    Fix RBAC for floating ips
    (cherry picked from commit 2dad1016cacaf36c4f6e2a0d9f68bf873bb75b93)

@martinpovolny martinpovolny mentioned this pull request Jun 7, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@martinpovolny martinpovolny

Labels
bug fine/backported rbac
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@PanSpagetka @miq-bot @simaishi @martinpovolny