-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change typ to 'service' for Service/Requests page #977
Change typ to 'service' for Service/Requests page #977
Conversation
@miq-bot add_label bug |
when /ae/ then "AutomateRequest" | ||
when /system/ then "MiqProvisionConfiguredSystemRequest" | ||
when /host/ then "MiqHostProvisionRequest" | ||
when /vm|service/ then "MiqProvisionRequest" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should not be using regex here, just plain strings. This code needs to be working for exact
@layout
values and we need to know what the actual matching values are for potential future
refactoring efforts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hard to grep for regexp too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, sounds reasonable, going to revise them
82c7eec
to
34eda33
Compare
Checked commit jzigmund@34eda33 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
…quests Change typ to 'service' for Service/Requests page (cherry picked from commit 5e0f438)
Fine backport details:
|
Distinguish 'Services/Requests' action and don't display pagination for the Request lists
https://bugzilla.redhat.com/show_bug.cgi?id=1436316