remove port_security_enabled from attributes passed to network create… #12736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tzumainn can you please fix those first 3 rubocop issue? Thx, Dan |
tzumainn
force-pushed
the
disable-port-security-enabled
branch
from
ef56190
to
9736438
Compare
|
@dclarizio done, thanks! |
|
Checked commit tzumainn@9736438 with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1 app/controllers/cloud_network_controller.rb
|
|
looks good |
chessbyte
pushed a commit
that referenced
this pull request
Nov 20, 2016
remove port_security_enabled from attributes passed to network create… (cherry picked from commit 89dba8b) https://bugzilla.redhat.com/show_bug.cgi?id=1394168
|
Euwe Backport details: $ git log -1
commit c4b464edd52eb1b6d1f3cc2844a0dfa1ac08dbb3
Author: Harpreet Kataria <hkataria@redhat.com>
Date: Fri Nov 18 17:24:20 2016 -0500
Merge pull request #12736 from tzumainn/disable-port-security-enabled
remove port_security_enabled from attributes passed to network create…
(cherry picked from commit 89dba8b56a472eed654bd309dd22ed2beb7eb60e)
https://bugzilla.redhat.com/show_bug.cgi?id=1394168 |
|
@simaishi Need Euwe BZ for https://bugzilla.redhat.com/show_bug.cgi?id=1394168 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The port_security_enabled attribute causes issues on older versions of OpenStack. We don't expose it in the UI, so it seems safe to simply comment it out in the controller, preventing the attribute from being passed into create/update API calls.
https://bugzilla.redhat.com/show_bug.cgi?id=1394168