Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add openstack floatingip/security group events #12941

Merged
merged 1 commit into from
Dec 6, 2016
Merged

add openstack floatingip/security group events #12941

merged 1 commit into from
Dec 6, 2016

Conversation

tzumainn
Copy link
Contributor

@tzumainn tzumainn commented Dec 1, 2016 •
edited
Loading

@gmcculloug
Copy link
Member

@tzumainn Any git issue or BZ to relate to this? Is it meant for 'Euwe' release?

Also, have you followed the steps in Creating a Pull Request for enhancements to ManageIQ Automate Domain?

@lfu Please review

@lfu
Copy link
Member

lfu commented Dec 5, 2016

Make sure the automate modeling has been exported either by UI or the script.
Otherwise it looks good to me.

@tzumainn
Copy link
Contributor Author

tzumainn commented Dec 5, 2016

Thanks for the comments! @lfu, is the script you mention 'Option 2' in the link that @gmcculloug provided? I'm more comfortable with a script than a UI : )

@lfu
Copy link
Member

lfu commented Dec 6, 2016

@tzumainn Right, what I meant is to use the rake automate export command. But usually I go with the UI.

@gmcculloug
Copy link
Member

@tzumainn Please comment on the questions from #12941 (comment) above.

@tzumainn
Copy link
Contributor Author

tzumainn commented Dec 6, 2016

@gmcculloug Ah, sorry - this is meant for the first Euwe point release. I'll try and get the files confirmed through the UI today!

@miq-bot
Copy link
Member

miq-bot commented Dec 6, 2016

Checked commit tzumainn@b95e74f with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1
0 files checked, 0 offenses detected
Everything looks good. 🍪

@tzumainn
Copy link
Contributor Author

tzumainn commented Dec 6, 2016

@lfu @gmcculloug I've confirmed that following the steps in the guide results in consistent YAML files, so I think this should be ready!

@gmcculloug gmcculloug merged commit 85eb661 into ManageIQ:master Dec 6, 2016
@gmcculloug gmcculloug added this to the Sprint 51 Ending Jan 2, 2017 milestone Dec 6, 2016
@tzumainn
Copy link
Contributor Author

@miq-bot add_label blocker
@miq-bot add_label bug

simaishi pushed a commit that referenced this pull request Jan 9, 2017
@gmcculloug @simaishi
Merge pull request #12941 from tzumainn/missing-network-events
b75d56d 
add openstack floatingip/security group events
(cherry picked from commit 85eb661)

https://bugzilla.redhat.com/show_bug.cgi?id=1406160
@simaishi
Copy link
Contributor

simaishi commented Jan 9, 2017

Euwe backport details:

$ git log -1
commit b75d56d996edbdcb80af0ea9163a517d952a3da9
Author: Greg McCullough <gmccullo@redhat.com>
Date:   Tue Dec 6 16:42:55 2016 -0500

    Merge pull request #12941 from tzumainn/missing-network-events
    
    add openstack floatingip/security group events
    (cherry picked from commit 85eb6613ea7f532243a8583a032cfe432b74d6e0)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1406160

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@gmcculloug gmcculloug

Labels
blocker bug core/events enhancement euwe/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tzumainn @gmcculloug @lfu @miq-bot @simaishi