Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an additional_regions key for amazon EC2 #12965

Merged
merged 1 commit into from
Dec 13, 2016
Merged

Add an additional_regions key for amazon EC2 #12965

merged 1 commit into from
Dec 13, 2016

Conversation

agrare
Copy link
Member

@agrare agrare commented Dec 2, 2016

Add an additional regions configuration key to add extra regions for Amazon.

https://bugzilla.redhat.com/show_bug.cgi?id=1389068

@agrare agrare mentioned this pull request Dec 2, 2016
Merged
Fryguy
Fryguy reviewed Dec 5, 2016
View reviewed changes
config/settings.yml
@@ -99,6 +99,7 @@
:miq_namespace: management-infra
:ems_amazon:
:disabled_regions: []
:additional_regions:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume you'd want the default to be an empty Array versus nil.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would allow it to have the same format as ManageIQ::Providers::Amazon::Regions::REGIONS so we could merge it without looping through the array, see https://github.com/ManageIQ/manageiq-providers-amazon/pull/89/files#diff-786c7b2d19b8663da84109af12cc8a96R75 and ManageIQ/manageiq-providers-amazon#89 (comment)

If you think it would be better as an array I can switch it to that

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Either an empty array or empty Hash... either way I feel like the default should not be nil.

@agrare agrare force-pushed the amazon/cloud/bz_1389068_custom_regions branch from d05630a to dc89321 Compare December 11, 2016 19:13
@miq-bot
Copy link
Member

miq-bot commented Dec 11, 2016

Checked commit agrare@dc89321 with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1
0 files checked, 0 offenses detected
Everything looks good. ⭐

@Fryguy Fryguy merged commit fc47fa7 into ManageIQ:master Dec 13, 2016
@Fryguy Fryguy added this to the Sprint 51 Ending Jan 2, 2017 milestone Dec 13, 2016
@Fryguy
Copy link
Member

Fryguy commented Dec 13, 2016

Dammit...I didn't see this was WIP and merged it. My tool didn't stop me :/

@Fryguy Fryguy changed the title [WIP] Add an additional_regions key for amazon EC2 WIP] Add an additional_regions key for amazon EC2 Dec 13, 2016
@Fryguy Fryguy changed the title WIP] Add an additional_regions key for amazon EC2 Add an additional_regions key for amazon EC2 Dec 13, 2016
@Fryguy Fryguy added enhancement and removed wip labels Dec 13, 2016
@agrare agrare deleted the amazon/cloud/bz_1389068_custom_regions branch December 14, 2016 17:59
@agrare
Copy link
Member Author

agrare commented Apr 27, 2017

EUWE BZ https://bugzilla.redhat.com/show_bug.cgi?id=1434152

simaishi pushed a commit that referenced this pull request Apr 28, 2017
@Fryguy @simaishi
Merge pull request #12965 from agrare/amazon/cloud/bz_1389068_custom_…
05046c0 
…regions

[WIP] Add an additional_regions key for amazon EC2
(cherry picked from commit fc47fa7)

https://bugzilla.redhat.com/show_bug.cgi?id=1434152
@simaishi
Copy link
Contributor

Euwe backport details:

$ git log -1
commit 05046c0f20183c9a129cf7350e6315f81ec0268f
Author: Jason Frey <fryguy9@gmail.com>
Date:   Tue Dec 13 16:49:19 2016 -0500

    Merge pull request #12965 from agrare/amazon/cloud/bz_1389068_custom_regions
    
    [WIP] Add an additional_regions key for amazon EC2
    (cherry picked from commit fc47fa7662f57cc1309de4c8d5d1e9278f064c48)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1434152

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fryguy Fryguy Fryguy left review comments

Assignees

@Fryguy Fryguy

Labels
enhancement euwe/backported providers/cloud
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@agrare @miq-bot @Fryguy @simaishi @chessbyte