Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Network Router: Raw commands are wrapped in raw prefixed methods #13072

Merged
merged 2 commits into from
Jan 9, 2017
Merged

Network Router: Raw commands are wrapped in raw prefixed methods #13072

merged 2 commits into from
Jan 9, 2017

Conversation

gildub
Copy link
Contributor

@gildub gildub commented Dec 9, 2016 •
edited
Loading

First commit fixes the method name. The caller has been merged in a separate PR. It will be broken until this is merged.

https://bugzilla.redhat.com/show_bug.cgi?id=1411170

@gildub gildub mentioned this pull request Dec 9, 2016
Closed
@gildub
Copy link
Contributor Author

gildub commented Dec 9, 2016

@miq-bot add_label ui

@miq-bot miq-bot added the ui label Dec 9, 2016
@gildub gildub closed this Jan 4, 2017
@gildub gildub reopened this Jan 4, 2017
@gildub gildub changed the title Network Manager: raw command must use raw Network Router: Fix method name Jan 4, 2017
@gildub
Copy link
Contributor Author

gildub commented Jan 4, 2017

@miq-bot del_label refactoring

@gildub
Copy link
Contributor Author

gildub commented Jan 4, 2017

@blomquisg, Happy new year!

As I just mentioned, the caller was merged, therefore this is not any more a refactor but a fix.

@gildub
Copy link
Contributor Author

gildub commented Jan 4, 2017

@miq-bot remove_label refactoring

@gildub gildub changed the title Network Router: Fix method name Network Router: Raw commands are wrapped in raw prefixed methods Jan 4, 2017
@miq-bot
Copy link
Member

miq-bot commented Jan 4, 2017

Checked commits https://github.com/gildub/manageiq/compare/4049495fc204c2bf4807b3132cbb6a2d8de15ccc~...c4a116d416bba5f5d34c92ca4c1aa3604ce01ce6 with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1
1 file checked, 2 offenses detected

app/models/manageiq/providers/openstack/network_manager/network_router.rb

  • ❕ - Line 107, Col 3 - Metrics/AbcSize - Assignment Branch Condition size for raw_remove_interface is too high. [20.32/20]
  • ❕ - Line 77, Col 3 - Metrics/AbcSize - Assignment Branch Condition size for raw_add_interface is too high. [20.32/20]

@miq-bot
Copy link
Member

miq-bot commented Jan 5, 2017

@gildub unrecognized command 'del_label', ignoring...

Accepted commands are: add_label, remove_label, rm_label, assign, set_milestone

@tzumainn
Copy link
Contributor

tzumainn commented Jan 9, 2017

@miq-bot add_label euwe/yes
@miq-bot add_label blocker
@miq-bot add_label bug

@tzumainn
Copy link
Contributor

tzumainn commented Jan 9, 2017

👍 this makes sense to me!

@blomquisg blomquisg merged commit 2ef53fa into ManageIQ:master Jan 9, 2017
@blomquisg blomquisg added this to the Sprint 52 Ending Jan 16, 2017 milestone Jan 9, 2017
@gildub gildub deleted the openstack_network_controller_network_router_fix_queue branch January 10, 2017 04:13
@gildub gildub mentioned this pull request Jan 10, 2017
Merged
@martinpovolny
Copy link
Member

Guys, you should split the tests to test separately backend and front end. E.g. when testing that a method is is called, then test for a method that the UI is calling directly. Not one or more levels deeper.

And of course it would help, especially if the isolation is not there, to run the UI tests ;-)

ping @blomquisg, @gildub, @tzumainn

@gildub gildub mentioned this pull request Jan 12, 2017
Closed
@gildub
Copy link
Contributor Author

gildub commented Jan 12, 2017

@martinpovolny, I agree, from now on with ui-classic split. Meanwhile that's not the case with Euwe.

simaishi pushed a commit that referenced this pull request Jan 16, 2017
@blomquisg @simaishi
Merge pull request #13072 from gildub/openstack_network_controller_ne…
1b2c2f2 
…twork_router_fix_queue

Network Router:  Raw commands are wrapped in raw prefixed methods
(cherry picked from commit 2ef53fa)

https://bugzilla.redhat.com/show_bug.cgi?id=1413677
@simaishi
Copy link
Contributor

Euwe backport details:

$ git log -1
commit 1b2c2f29b3dc75feec767e2da2b3a744aea600cb
Author: Greg Blomquist <blomquisg@gmail.com>
Date:   Mon Jan 9 13:01:21 2017 -0500

    Merge pull request #13072 from gildub/openstack_network_controller_network_router_fix_queue
    
    Network Router:  Raw commands are wrapped in raw prefixed methods
    (cherry picked from commit 2ef53fa263866f753c155a96fbb8db05b700d4fb)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1413677

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
blocker bug euwe/backported providers/cloud
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@gildub @miq-bot @tzumainn @martinpovolny @simaishi @blomquisg @Fryguy @chessbyte @mzazrivec