Notifications: use initiator's tenant when subject lacks tenant relationship #13081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@isimluk Looks good. Automate passes in the user as the initiator. |
gtanzillo
reviewed
Dec 9, 2016
| if subject.respond_to? :tenant | ||
| subject.tenant | ||
| elsif initiator.kind_of? User | ||
| initiator.current_group.try(:tenant) |
There was a problem hiding this comment.
@isimluk I think you can just call current_tenant on the user instance here because it's delegated to the MiqGroup class in the User class.
|
Checked commit isimluk@ac7a08e with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1 |
simaishi
pushed a commit
that referenced
this pull request
Jan 9, 2017
Notifications: use initiator's tenant when subject lacks tenant relationship (cherry picked from commit 6f6b526) https://bugzilla.redhat.com/show_bug.cgi?id=1411511
|
Euwe backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugzilla.redhat.com/show_bug.cgi?id=1400246
Automate users may pass in a
$subjectthat lacks tenant relationship. In that case we should use initiators' tenant to determine audience of given notification.Note: We still need to amend automate code to pass in automate user as initiator.
/cc @tinaafitz
@miq-bot add_label core, enhancement, euwe/yes
@miq-bot assign @gtanzillo