Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disallow subnet deletion if it has an associated instance #13098

Merged
merged 1 commit into from
Dec 22, 2016
Merged

Disallow subnet deletion if it has an associated instance #13098

merged 1 commit into from
Dec 22, 2016

Conversation

tzumainn
Copy link
Contributor

@tzumainn tzumainn commented Dec 9, 2016

Also fix some inconsistent feature names

https://bugzilla.redhat.com/show_bug.cgi?id=1397469

@miq-bot
Copy link
Member

miq-bot commented Dec 9, 2016

Checked commit tzumainn@1ba3775 with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1
1 file checked, 0 offenses detected
Everything looks good. 🍪

@blomquisg
Copy link
Member

Looks good ... @durandom can I get a thumbs up from you?

durandom
durandom approved these changes Dec 13, 2016
View reviewed changes
Copy link
Member

@durandom durandom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@blomquisg @tzumainn 👍 from me.
This unsupported_reason_add(:delete_subnet would have blown up once it would have been triggered.
So, good catch!

@tzumainn
Copy link
Contributor Author

@miq-bot add_label euwe/yes
@miq-bot add_label bug
@miq-bot add_label blocker

@blomquisg blomquisg merged commit 255f49a into ManageIQ:master Dec 22, 2016
@blomquisg blomquisg added this to the Sprint 51 Ending Jan 2, 2017 milestone Dec 22, 2016
@tzumainn tzumainn mentioned this pull request Jan 10, 2017
Merged
simaishi pushed a commit that referenced this pull request Jan 10, 2017
@blomquisg @simaishi
Merge pull request #13098 from tzumainn/subnet-delete-check
3b21ac0 
Disallow subnet deletion if it has an associated instance
(cherry picked from commit 255f49a)

https://bugzilla.redhat.com/show_bug.cgi?id=1411516
@simaishi
Copy link
Contributor

Euwe backport details:

$ git log -1
commit 3b21ac0c2da0ea2d002835a34c4c506314fd3617
Author: Greg Blomquist <blomquisg@gmail.com>
Date:   Thu Dec 22 13:43:40 2016 -0500

    Merge pull request #13098 from tzumainn/subnet-delete-check
    
    Disallow subnet deletion if it has an associated instance
    (cherry picked from commit 255f49abac66b9f15d25fa938f77cc1a7781720c)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1411516

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@durandom durandom durandom approved these changes

Assignees

@blomquisg blomquisg

Labels
blocker bug euwe/backported providers/cloud providers/network
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@tzumainn @miq-bot @blomquisg @simaishi @durandom @Fryguy @chessbyte