UI Split #13303
Merged
UI Split #13303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change is to be consistent with the plugins / engines we use (providers, etc.).
We cannot extract locale path from a gettext domains, that is being used in a chain / merge repo. We need to do this ourselves.
This task collects all .po files from all registered ManageIQ plugins / engines and converts them to .json files for them to be consumed by javascript. This is very similar to gettext:po_to_json, except this task takes into account all the engines (plugins), not just the core application.
Depends on companion PR in UI repo.
Fryguy
reviewed
Dec 22, 2016
| @@ -1,6 +1,7 @@ | |||
| module EvmTestHelper | |||
| VMDB_EXCLUDED_SPEC_DIRECTORIES = ["migrations"].freeze | |||
| VMDB_EXCLUDED_SPEC_DIRECTORIES = %w(replication migrations).freeze | |||
There was a problem hiding this comment.
@martinpovolny This line is going to have to go back to just being migrations. We previously removed the replication suite.
There was a problem hiding this comment.
Nevermind I was reading it backwards I guess :)
|
<github_pr_commenter_batch />Some comments on commits martinpovolny/manageiq@1a9fd56~...db74982 locale/en/manageiq.po
locale/es/manageiq.po
locale/fr/manageiq.po
locale/ja/manageiq.po
locale/manageiq.pot
locale/zh_CN/manageiq.po
|
|
Checked commits martinpovolny/manageiq@1a9fd56~...db74982 with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1 Gemfile
config/dictionary_strings.rb
config/yaml_strings.rb
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Splitting the UI into new repo: manageiq-ui-classic
Companion branch: https://github.com/martinpovolny/manageiq-ui-classic/tree/final_cherryCompanion branch: https://github.com/martinpovolny/manageiq-ui-classic/tree/final_cherry_specsNew repo located at https://github.com/ManageIQ/manageiq-ui-classic