Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Openstack infra ssh keypair validation fixes #13445

Conversation

petrblaho
Copy link

@petrblaho petrblaho commented Jan 11, 2017

These are 2 fixes for OpenStack Infra SSH Key Pair validation code.

Contains code form #13159 and #13275

Solves:
https://bugzilla.redhat.com/show_bug.cgi?id=1376605
https://bugzilla.redhat.com/show_bug.cgi?id=1406443

@petrblaho
Copy link
Author

@miq-bot add_label euwe/yes
@miq-bot add_label blocker
@miq-bot add_label bug
@miq-bot add_label providers/openstack/infra

@petrblaho petrblaho force-pushed the openstack-infra-ssh-keypair-validation-fixes branch from f5d161f to 135abae Compare January 11, 2017 14:38
Adds ems_cluster association to host_openstack_infra Factory.
Adds test to make sure that we skip Hosts without EmsCluster associated.
@petrblaho petrblaho force-pushed the openstack-infra-ssh-keypair-validation-fixes branch from 135abae to 740d3b6 Compare January 11, 2017 16:14
@miq-bot
Copy link
Member

miq-bot commented Jan 11, 2017

Some comments on commits petrblaho/manageiq@40b1773~...740d3b6

spec/models/manageiq/providers/openstack/infra_manager_spec.rb

  • ⚠️ - 21 - Detected allow_any_instance_of. This RSpec method is highly discouraged, please only use when absolutely necessary.
  • ⚠️ - 28 - Detected allow_any_instance_of. This RSpec method is highly discouraged, please only use when absolutely necessary.
  • ⚠️ - 35 - Detected allow_any_instance_of. This RSpec method is highly discouraged, please only use when absolutely necessary.
  • ⚠️ - 42 - Detected allow_any_instance_of. This RSpec method is highly discouraged, please only use when absolutely necessary.

@miq-bot
Copy link
Member

miq-bot commented Jan 11, 2017

Checked commits petrblaho/manageiq@40b1773~...740d3b6 with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1
3 files checked, 6 offenses detected

spec/factories/host.rb

spec/models/manageiq/providers/openstack/infra_manager_spec.rb

@petrblaho petrblaho changed the title [WIP] Openstack infra ssh keypair validation fixes Openstack infra ssh keypair validation fixes Jan 11, 2017
@tzumainn
Copy link
Contributor

👍 looks good to me as the combination of two previous PRs!

@tzumainn
Copy link
Contributor

@miq-bot assign @blomquisg

@miq-bot miq-bot assigned blomquisg and unassigned tzumainn Jan 13, 2017
@blomquisg blomquisg merged commit df1fcf1 into ManageIQ:master Jan 13, 2017
@blomquisg blomquisg added this to the Sprint 52 Ending Jan 16, 2017 milestone Jan 13, 2017
simaishi pushed a commit that referenced this pull request Jan 16, 2017
@simaishi
Copy link
Contributor

Euwe backport details:

$ git log -1
commit 14006476d7a126e98b0e3e9ea80ede0d44310010
Author: Greg Blomquist <blomquisg@gmail.com>
Date:   Fri Jan 13 14:58:24 2017 -0500

    Merge pull request #13445 from petrblaho/openstack-infra-ssh-keypair-validation-fixes
    
    Openstack infra ssh keypair validation fixes
    (cherry picked from commit df1fcf14f2439523e478cbfbaf79159eb0d78333)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1413207
    https://bugzilla.redhat.com/show_bug.cgi?id=1413210

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants