bulk unassign tags on services and vms

[jntullo]

Adds ability to bulk unassign tags to multiple services / VM resources

Example:

{
        'action'    => 'unassign_tags',
        'resources' => [
          { 'id' => 1, 'tags' => [{'id' => 999}] },
          { 'id' => 2, 'tags' => [{'id' => 999}] }
        ]
      }

Links

• Pivotal Tracker Ticket

@miq-bot assign @abellotti
@miq-bot add_label enhancement, api

[miq-bot]

Checked commit jntullo@6fa2e6e with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
2 files checked, 0 offenses detected
Everything looks good. ⭐

[imtayadeway]

Is it possible that this could blow up while unassigning one of the tags, having already succeeded at some, and report a failure for all?

[jntullo]

@imtayadeway I suppose anything is possible, although unlikely. I can add in a rescue block around the tags_unassign_resource

[imtayadeway]

I suppose anything is possible, although unlikely

Yes, agreed 😄

[abellotti]

This can be done in a follow-up PR to handle exceptions for both assign_tags and unassign_tags (which have now parity implementation) and return the appropriate failed action_result for the individual tag and not the whole lot. Thanks.

[imtayadeway]

@jntullo this LGTM with small nit above. Great work! 🎈

[abellotti]

LGTM!! 👍