Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sample C&U chart reports for specs #13998

Merged
merged 1 commit into from
Feb 22, 2017

Conversation

PanSpagetka
Copy link
Contributor

@PanSpagetka PanSpagetka commented Feb 21, 2017

Add sample C&U chart reports for specs in my PR in UI repo. One with daily data without grouping by tag categories and one with grouping by tag categories.

This need to be merge first.

Links

ManageIQ/manageiq-ui-classic#382

@miq-bot
Copy link
Member

miq-bot commented Feb 21, 2017

Checked commit PanSpagetka@7658c1e with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 20 offenses detected

spec/support/report_helper.rb

@martinpovolny
Copy link
Member

Please, check if we can move this file to the UI repo. Thx!

@martinpovolny martinpovolny merged commit 8c51a89 into ManageIQ:master Feb 22, 2017
@simaishi
Copy link
Contributor

simaishi commented Mar 7, 2017

@PanSpagetka @martinpovolny ManageIQ/manageiq-ui-classic#382 was euwe/yes so I backported, but now Travis is failing. As per the comment in ManageIQ/manageiq-ui-classic#382, don't we need this in Euwe??

@martinpovolny
Copy link
Member

@PanSpagetka : seems to me that we should backport this one too. Can you confirm?

@PanSpagetka
Copy link
Contributor Author

@martinpovolny @simaishi Yep, this should be backported too.

simaishi pushed a commit that referenced this pull request Mar 8, 2017
Add sample C&U chart reports for specs
(cherry picked from commit 8c51a89)
@simaishi
Copy link
Contributor

simaishi commented Mar 8, 2017

Euwe backport details:

$ git log -1
commit 6810bc79ab482c655a624e88124ae35fd300f939
Author: Martin Povolny <mpovolny@redhat.com>
Date:   Wed Feb 22 16:12:02 2017 +0100

    Merge pull request #13998 from PanSpagetka/fix-units-in-CU-grouped
    
    Add sample C&U chart reports for specs
    (cherry picked from commit 8c51a891fed91cdfbac7e9e91e8c5f61ef9ddc36)

@chessbyte chessbyte added this to the Sprint 55 Ending Feb 27, 2017 milestone Mar 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants