Validate content for non-required fields #421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romanblanco
changed the title
romanblanco
force-pushed
the
bz1670051
branch
from
3027990
to
366f4c7
Compare
|
Checked commit romanblanco@366f4c7 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
himdel
reviewed
Sep 24, 2019
| } else { | ||
| if (field.type === 'DialogFieldDateControl' || | ||
| field.type === 'DialogFieldDateTimeControl') { | ||
| if (!(_.isDate(value) || value === null)) { |
There was a problem hiding this comment.
null is valid when not required
the code is right, my eyes are not ;)
This was referenced Oct 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1670051
In case the
DateControlorDateTimeControlfield are not set asrequired, the added code tests if the entered value is a date or an empty field and therefore valid.