Skip to content

Commit

Permalink
CI: Pin Emscripten version for reproducible builds
Browse files Browse the repository at this point in the history
Emscripten is a fast-moving target which gets tons of improvements all the time,
but it's not rare that some regressions affect us and make our CI builds fail.
(See e.g. godotengine#33728, godotengine#35237, godotengine#39168, godotengine#40563, and godotengine#40914.)

Let's pin to a stable version to avoid having external factors impact our CI,
and update this version manually regularly in a PR to ensure that the new
version works well for us.
  • Loading branch information
akien-mga authored and MarcusElg committed Oct 19, 2020
1 parent e88296c commit 1b7c89d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/javascript_builds.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ on: [push, pull_request]
env:
GODOT_BASE_BRANCH: master
SCONS_CACHE_LIMIT: 4096
EM_VERSION: latest
EM_VERSION: 1.39.20
EM_CACHE_FOLDER: 'emsdk-cache'

jobs:
Expand Down

0 comments on commit 1b7c89d

Please sign in to comment.