Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Wpf support (control and sample) #12

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

paviad
Copy link

@paviad paviad commented Dec 24, 2021

I conformed to the Avalonia example as much as I could, but I gave up trying to learn ReactiveUI so I did not use it at all.

@MarcusWichelmann MarcusWichelmann self-assigned this Dec 25, 2021
@paviad
Copy link
Author

paviad commented Dec 27, 2021

I built this for .NET 6... the pipeline uses .NET 3.1. How do you want to proceed?

@Wildimp
Copy link

Wildimp commented Nov 19, 2023

Hey @paviad,
I was looking for a wpf integration for MarcusWVnc and just found your pull request. It works like a charm to connect and interact with my vnc server but i have one problem with it: When i try to disconnect the client by using the CloseAsync method of the RfbConnection, it won't disconnect and just give me an OperationCanceledException. Did you test this case in your integration? You have any idea what could be the issue?

@paviad
Copy link
Author

paviad commented Dec 3, 2023

I honestly do not remember, last I touched this project was end of 2021, and I haven't used it since. I'll see if I can find the time to have a look.

@Wildimp
Copy link

Wildimp commented Dec 4, 2023

Thanks for taking your time to answer me. In the meantime i found out that the problem was on my side. I mishandled the cancelation token. Your implementation works just as intented. Thanks again for providing a wpf implementation.,

@paviad paviad force-pushed the master branch 8 times, most recently from 500e1eb to a1dff6b Compare July 26, 2024 14:18
@paviad
Copy link
Author

paviad commented Jul 26, 2024

I've incorporated #26 into my fork at #12 (https://github.com/paviad/MarcusW.VncClient)

@paviad
Copy link
Author

paviad commented Jul 28, 2024

I added an in memory client using the Skia library (Windows)

@paviad
Copy link
Author

paviad commented Jul 29, 2024

Incorporated PR #28 into this one

@frogcrush
Copy link

Some comments from my end about the sample:

  • Autoresize doesn't work. It seems that you are setting it based on the ActualHeight and ActualWidth which is incorrect due to being in a ScrollViewer. The ScrollViewer width and height likely changes AFTER the event is called so you are sending the incorrect ActualWidth and ActualHeight, so no resize actually happens on the server-side.
  • ErrorMessage is not displayed unless the connection succeeds
  • No input for the Password field?

@paviad
Copy link
Author

paviad commented Jul 31, 2024

Some comments from my end about the sample:

  • Autoresize doesn't work. It seems that you are setting it based on the ActualHeight and ActualWidth which is incorrect due to being in a ScrollViewer. The ScrollViewer width and height likely changes AFTER the event is called so you are sending the incorrect ActualWidth and ActualHeight, so no resize actually happens on the server-side.
  • ErrorMessage is not displayed unless the connection succeeds
  • No input for the Password field?

Fixed last two issues (error message and interactive password)

Regarding auto size, I couldn't reproduce the problem you mention, even though I am using ActualWidth and ActualHeight, when I actually tested it it worked fine with or without scroll bars on the view, see this video:

autosize

@paviad
Copy link
Author

paviad commented Aug 7, 2024

Incorporated PR #29 into this one (for Avalonia and Wpf)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants