G33 minor change #6621
Closed
G33 minor change #6621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-further named remaining tests -A and O parameters obsolete -quick homing with home_delta() -preventing premature end
Closed
bgort
reviewed
May 7, 2017
Marlin/Marlin_main.cpp
Outdated
| @@ -5082,7 +5078,7 @@ void home_all_axes() { gcode_G28(); } | |||
|
|
|||
| const int8_t verbose_level = code_seen('V') ? code_value_byte() : 1; | |||
| if (!WITHIN(verbose_level, 0, 2)) { | |||
| SERIAL_PROTOCOLLNPGM("?(V)erbose level is implausible (0-2)."); | |||
| SERIAL_PROTOCOLLNPGM("?(V)erbose Level is implausible (0-2)."); | |||
There was a problem hiding this comment.
This was changed in a previous merge, and it isn't important really, but it suggests a rebase may be needed?
There was a problem hiding this comment.
I copied the whole G33 routine from a non-Git local copy on my drive I use to develop and beta test. Hence not 100% up to date with the latest merges....
There was a problem hiding this comment.
Yeah, no worries. Just better to not undo recent changes, if possible.
|
FWIW, it looks good to me.. but I don't have a delta so can't test. |
|
tested and all is well |
use the first probe result to prevent scraping the bed or floating to high above it
|
Squashed into #6700 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-further named remaining tests
-A and O parameters obsolete
-quick homing with home_delta()
-preventing premature end