Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: When a transfer from rquickshare to an android device is running, cancelling it isn't properly handled. #128

Closed
103sbavert opened this issue Jul 11, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@103sbavert
Copy link

When a transfer initiated from a PC to an android phone is cancelled from the phone itself, it errors and says "Unexpected disconnection" after completely finishing the transfer (as opposed to stopping in the middle). It should instead inform the user the connection was cancelled.

Version: 0.10.1
OS: Arch Linux
AUR Package: r-quick-share (non-bin)

@Martichou
Copy link
Owner

You're sure the transfer did finish? That seems weird cause it should exit the loop directly.. or maybe the message isn't received 🤔
Gonna check.

@103sbavert
Copy link
Author

The transfer didn't "finish", but it didn't cancel either. It kind of just got error'd but it showed a full green circle.

@Martichou Martichou changed the title Bug: When a transfer from qnearbyshare to an android device is running, cancelling it isn't properly handled. bug: When a transfer from rquickshare to an android device is running, cancelling it isn't properly handled. Aug 3, 2024
@Martichou Martichou added the bug Something isn't working label Aug 5, 2024
@Martichou
Copy link
Owner

Upon checking again, it seems like the Android device doesn't send a Cancelled packet for whatever reason...
But the transfer did stopped on my side. I've added a visual information (the circle will be full red if error/cancelled/rejected).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants