Merge pull request Louisvdw#810 from mr-manuel/dev

Changes 2023.09.19
Marvo2011 · Sep 19, 2023 · 4c2b89c · 4c2b89c
2 parents 88274bf + 81c20ff
commit 4c2b89c
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 4 deletions.
diff --git a/etc/dbus-serialbattery/bms/mnb.py b/etc/dbus-serialbattery/bms/mnb.py
@@ -2,9 +2,8 @@
 
 # # MNB is disabled by default
 # can be enabled by specifying it in the BMS_TYPE setting in the "config.ini"
-# https://github.com/Louisvdw/dbus-serialbattery/commit/65241cbff36feb861ff43dbbcfb2b495f14a01ce
-# remove duplicate MNB lines
-# https://github.com/Louisvdw/dbus-serialbattery/commit/23afec33c2fd87fd4d4c53516f0a25f290643c82
+# https://github.com/Louisvdw/dbus-serialbattery/issues/590
+# https://community.victronenergy.com/comments/231924/view.html
 
 from battery import Protection, Battery, Cell
 from utils import logger

diff --git a/etc/dbus-serialbattery/dbus-serialbattery.py b/etc/dbus-serialbattery/dbus-serialbattery.py
@@ -72,6 +72,9 @@
 
 
 def main():
+    # NameError: free variable 'expected_bms_types' referenced before assignment in enclosing scope
+    global expected_bms_types
+
     def poll_battery(loop):
         helper.publish_battery(loop)
         return True

diff --git a/etc/dbus-serialbattery/utils.py b/etc/dbus-serialbattery/utils.py
@@ -38,7 +38,7 @@ def _get_list_from_config(
 
 
 # Constants
-DRIVER_VERSION = "1.0.20230917dev"
+DRIVER_VERSION = "1.0.20230919dev"
 zero_char = chr(48)
 degree_sign = "\N{DEGREE SIGN}"