server.jsonapi has no patternProperties

[tpurcell90]

In the current version of pydanitc patternProperties can only be added inside sub-elements of properties. If that is fixed then remove items from optimade.server.models.jsonapi.Attributes and optimade.server.models.jsonapi.Realationships and make it match that new formalism.

Somewhere in the creation of the openapi.json file the patternProperties is lost (likely something is using an old version of pydantic that converts a Dict object to object if the key is not a string).

[tpurcell90]

Merge request #41 removed the hack and added documentation that the disallowed types should not be used. At the moment this is not enforced.

[CasperWA]

Concerning relationships, this has been remedied by using BaseResource (see here) that only has id and type. Resource then subclasses this and adds attributes.
For relationships, they then only need to use BaseResource.

Concerning the restriction of attributes that was introduced by #24 here, this has since been removed, but it should probably be reintroduced, since Attributes now allow extra fields.
This may however be remedied by a pydantic validator, but it will not be reflected in the openapi.json (only through the doc-string, which may be fine?).

[CasperWA]

It seems the root_validator needed for this task is not introduced until pydantic v1.0b1, and fastapi has only implemented pydantic up to v0.32.2 (and that's for the latest fastapi version, which we are still not using).
There is hope though, the root concept was introduced in v0.30 of pydantic, meaning if we update fastapi we may be able to use an older version of the root_validator concept.