Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documented json #41

Merged
merged 4 commits into from
Jun 14, 2019
Merged

Documented json #41

merged 4 commits into from
Jun 14, 2019

Conversation

tpurcell90
Copy link
Contributor

Better documented JSON and redoing of some of the hacks I made for the patternProperties issue

Put in docstrings into jsonapi file
I updated the documentation and added in the documentation the regex restrictions.

The hack I made previously does not work
@tpurcell90 tpurcell90 requested a review from ltalirz June 14, 2019 09:53
ltalirz
ltalirz previously approved these changes Jun 14, 2019
Copy link
Member

@ltalirz ltalirz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@tpurcell90 tpurcell90 requested a review from ml-evs June 14, 2019 10:16
Copy link
Member

@ml-evs ml-evs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tpurcell90 tpurcell90 merged commit e801582 into master Jun 14, 2019
@CasperWA CasperWA deleted the documented_json branch November 8, 2019 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants